Keep safe haven cash for unbuyable small accounts - #110
Conversation
cf81991 to
b27b2a4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf81991371
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| target_mv[normalized_symbol] = 0.0 | ||
| target_weights[normalized_symbol] = 0.0 |
There was a problem hiding this comment.
When a small account's only positive risk target is projected to cash, this branch zeroes the safe-haven target but leaves execution_summary["realized_safe_haven_weight"] at the value computed earlier from the pre-substitution weights. In the new SOXX/BOXX scenario this means reconciliation/reporting can show an 85% realized safe-haven weight while target_vs_current and order generation treat BOXX as 0%, so the summary is internally inconsistent; update the realized safe-haven weight after this substitution.
Useful? React with 👍 / 👎.
b27b2a4 to
78ab532
Compare
78ab532 to
935704e
Compare
1 participant
Summary
Verification